lkml.org 
[lkml]   [2018]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: set kernel end address properly
On Mon, 23 Apr 2018 10:52:21 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Em Fri, Apr 20, 2018 at 06:23:58PM -0500, Kim Phillips escreveu:
> > On Fri, 20 Apr 2018 08:59:15 +0900
> > Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > > The map_groups__fixup_end() was called to set end addresses of kernel
> > > map and module maps. But now machine__create_modules() is set the end
> > > address of modules properly, the only remaining piece is the kernel map.
> > > We can set it with adjacent module's address directly instead of calling
> > > the map_groups__fixup_end(). If there's no module after the kernel map,
> > > the end address will be ~0ULL.
> > >
> > > Since it also changes the start address of the kernel map, it needs to
> > > re-insert the map to the kmaps in order to keep a correct ordering. Kim
> > > reported that it caused problems on ARM64.
> > >
> > > Reported-by: Kim Phillips <kim.phillips@arm.com>
> > > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > > ---
> >
> > Acked-by: Kim Phillips <kim.phillips@arm.com>
>
> So as you actually seem to have tested this, I'm taking this as a
> Tested-by instead, to better reflect what you did, ok?

Sure.

Thanks,

Kim

\
 
 \ /
  Last update: 2018-04-23 16:56    [W:0.060 / U:1.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site