| Date | Mon, 23 Apr 2018 14:11:10 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH 2/4] ALSA: usb-audio: ADC3: Fix channel mapping conversion for ADC3. |
| |
On Fri, 20 Apr 2018 19:03:25 +0200, Jorge Sanjuan wrote: > > From: Michael Drake <michael.drake@codethink.co.uk> > > The channel mapping is defined by bChRelationship, not bChPurpose. > > Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
The change looks OK, but your sign-off is missing. If you submit a patch, please give always your signed-off-by tag, no matter whether it's your original patch or not.
Also, the Fixes tag would be helpful for such a correction.
thanks,
Takashi
|