lkml.org 
[lkml]   [2018]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 10/61] gpio: simplify getting .drvdata
    From
    Date
    Hi Wolfram,

    On 21.4.2018 18:23, Wolfram Sang wrote:
    > Hi Michal,
    >
    > Thanks for the reviews!
    >
    >> There are two more occurences in this gpio-zynq driver.
    >> zynq_gpio_resume, zynq_gpio_suspend. It wasn't detected because these
    >> two lines are not together. But the same change can be applied for them too.
    >
    > Not really. The rule would have matched if there was just "something"
    > inbetween. It did not match because the "something" involves the
    > variable 'pdev', so we can't remove it. And just changing towards
    > 'dev_get_drvdata' and keeping 'pdev' was not worth the hazzle in my
    > book. Especially since I think the code should probably get refactored.
    > Calling platform_get_irq() in suspend/resume paths in order to get the
    > irq_data looks a little expensive to me, but I haven't tested it.
    >

    ok. Thanks. I have overlooked that.

    Thanks,
    Michal

    \
     
     \ /
      Last update: 2018-04-23 08:05    [W:4.084 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site