Messages in this thread Patch in this message | | | From | Jiri Olsa <> | Subject | [PATCH 3/9] perf stat: Keep the / modifier separator in fallback | Date | Mon, 23 Apr 2018 11:08:17 +0200 |
| |
The perf stat fallback for EACCES error sets exclude_kernel for event and repeats the open. In addition, it also changes the name of the event to reflect that change by adding the 'u' modifier.
But it does not take into account the '/' separator, so the event name can end up mangled, like: (note the '/:' characters)
$ perf stat -e cpu/cpu-cycles/ kill ... 386,832 cpu/cpu-cycles/:u
Adding the code to check on the '/' separatos and set following event name:
$ perf stat -e cpu/cpu-cycles/ kill ... 388,548 cpu/cpu-cycles/u
Link: http://lkml.kernel.org/n/tip-bh7wxrci19km6iwbv4qg555o@git.kernel.org Signed-off-by: Jiri Olsa <jolsa@kernel.org> --- tools/perf/util/evsel.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 1ac8d9236efd..7472f876cd70 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -2754,8 +2754,14 @@ bool perf_evsel__fallback(struct perf_evsel *evsel, int err, (paranoid = perf_event_paranoid()) > 1) { const char *name = perf_evsel__name(evsel); char *new_name; + const char *sep = ":"; - if (asprintf(&new_name, "%s%su", name, strchr(name, ':') ? "" : ":") < 0) + /* Is there already the separator in the name. */ + if (strchr(name, '/') || + strchr(name, ':')) + sep = ""; + + if (asprintf(&new_name, "%s%su", name, sep) < 0) return false; if (evsel->name) -- 2.13.6
| |