Messages in this thread Patch in this message | | | Date | Tue, 24 Apr 2018 00:52:48 +0300 | From | Alexey Dobriyan <> | Subject | [PATCH] proc: use "unsigned int" for /proc/*/stack |
| |
struct stack_trace::nr_entries is defined as "unsigned int" (YAY!) so the iterator should be unsigned as well.
It saves 1 byte of code or something like that.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> ---
fs/proc/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
--- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -430,7 +430,6 @@ static int proc_pid_stack(struct seq_file *m, struct pid_namespace *ns, struct stack_trace trace; unsigned long *entries; int err; - int i; entries = kmalloc(MAX_STACK_TRACE_DEPTH * sizeof(*entries), GFP_KERNEL); if (!entries) @@ -443,6 +442,8 @@ static int proc_pid_stack(struct seq_file *m, struct pid_namespace *ns, err = lock_trace(task); if (!err) { + unsigned int i; + save_stack_trace_tsk(task, &trace); for (i = 0; i < trace.nr_entries; i++) {
| |