lkml.org 
[lkml]   [2018]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 168/196] HID: i2c-hid: Fix resume issue on Raydium touchscreen device
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Aaron Ma <aaron.ma@canonical.com>

    commit 3e83eda467050f13fa69d888993458b76e733de9 upstream.

    When Rayd touchscreen resumed from S3, it issues too many errors like:
    i2c_hid i2c-RAYD0001:00: i2c_hid_get_input: incomplete report (58/5442)

    And all the report data are corrupted, touchscreen is unresponsive.

    Fix this by re-sending report description command after resume.
    Add device ID as a quirk.

    Cc: stable@vger.kernel.org
    Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hid/hid-ids.h | 3 +++
    drivers/hid/i2c-hid/i2c-hid.c | 13 +++++++++++++
    2 files changed, 16 insertions(+)

    --- a/drivers/hid/hid-ids.h
    +++ b/drivers/hid/hid-ids.h
    @@ -519,6 +519,9 @@
    #define I2C_VENDOR_ID_HANTICK 0x0911
    #define I2C_PRODUCT_ID_HANTICK_5288 0x5288

    +#define I2C_VENDOR_ID_RAYD 0x2386
    +#define I2C_PRODUCT_ID_RAYD_3118 0x3118
    +
    #define USB_VENDOR_ID_HANWANG 0x0b57
    #define USB_DEVICE_ID_HANWANG_TABLET_FIRST 0x5000
    #define USB_DEVICE_ID_HANWANG_TABLET_LAST 0x8fff
    --- a/drivers/hid/i2c-hid/i2c-hid.c
    +++ b/drivers/hid/i2c-hid/i2c-hid.c
    @@ -47,6 +47,7 @@
    /* quirks to control the device */
    #define I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV BIT(0)
    #define I2C_HID_QUIRK_NO_IRQ_AFTER_RESET BIT(1)
    +#define I2C_HID_QUIRK_RESEND_REPORT_DESCR BIT(2)

    /* flags */
    #define I2C_HID_STARTED 0
    @@ -171,6 +172,8 @@ static const struct i2c_hid_quirks {
    I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV },
    { I2C_VENDOR_ID_HANTICK, I2C_PRODUCT_ID_HANTICK_5288,
    I2C_HID_QUIRK_NO_IRQ_AFTER_RESET },
    + { I2C_VENDOR_ID_RAYD, I2C_PRODUCT_ID_RAYD_3118,
    + I2C_HID_QUIRK_RESEND_REPORT_DESCR },
    { 0, 0 }
    };

    @@ -1220,6 +1223,16 @@ static int i2c_hid_resume(struct device
    if (ret)
    return ret;

    + /* RAYDIUM device (2386:3118) need to re-send report descr cmd
    + * after resume, after this it will be back normal.
    + * otherwise it issues too many incomplete reports.
    + */
    + if (ihid->quirks & I2C_HID_QUIRK_RESEND_REPORT_DESCR) {
    + ret = i2c_hid_command(client, &hid_report_descr_cmd, NULL, 0);
    + if (!ret)
    + return ret;
    + }
    +
    if (hid->driver && hid->driver->reset_resume) {
    ret = hid->driver->reset_resume(hid);
    return ret;

    \
     
     \ /
      Last update: 2018-04-22 16:02    [W:3.937 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site