lkml.org 
[lkml]   [2018]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 043/196] usb: dwc3: pci: Properly cleanup resource
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

    commit cabdf83dadfb3d83eec31e0f0638a92dbd716435 upstream.

    Platform device is allocated before adding resources. Make sure to
    properly cleanup on error case.

    Cc: <stable@vger.kernel.org>
    Fixes: f1c7e7108109 ("usb: dwc3: convert to pcim_enable_device()")
    Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/dwc3/dwc3-pci.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/dwc3/dwc3-pci.c
    +++ b/drivers/usb/dwc3/dwc3-pci.c
    @@ -222,7 +222,7 @@ static int dwc3_pci_probe(struct pci_dev
    ret = platform_device_add_resources(dwc->dwc3, res, ARRAY_SIZE(res));
    if (ret) {
    dev_err(dev, "couldn't add resources to dwc3 device\n");
    - return ret;
    + goto err;
    }

    dwc->pci = pci;

    \
     
     \ /
      Last update: 2018-04-22 18:10    [W:3.979 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site