lkml.org 
[lkml]   [2018]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 057/196] CIFS: fix sha512 check in cifs_crypto_secmech_release
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Gustavo A. R. Silva <gustavo@embeddedor.com>

    commit 70e80655f58e17a2e38e577e1b4fa7a8c99619a0 upstream.

    It seems this is a copy-paste error and that the proper variable to use
    in this particular case is _sha512_ instead of _md5_.

    Addresses-Coverity-ID: 1465358 ("Copy-paste error")
    Fixes: 1c6614d229e7 ("CIFS: add sha512 secmech")
    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    Reviewed-by: Aurelien Aptel <aaptel@suse.com>
    CC: Stable <stable@vger.kernel.org>
    Signed-off-by: Steve French <smfrench@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/cifs/cifsencrypt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/cifs/cifsencrypt.c
    +++ b/fs/cifs/cifsencrypt.c
    @@ -829,7 +829,7 @@ cifs_crypto_secmech_release(struct TCP_S
    server->secmech.md5 = NULL;
    }

    - if (server->secmech.md5) {
    + if (server->secmech.sha512) {
    crypto_free_shash(server->secmech.sha512);
    server->secmech.sha512 = NULL;
    }

    \
     
     \ /
      Last update: 2018-04-22 18:07    [W:2.850 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site