lkml.org 
[lkml]   [2018]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 157/164] autofs: mount point create should honour passed in mode
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ian Kent <raven@themaw.net>

    commit 1e6306652ba18723015d1b4967fe9de55f042499 upstream.

    The autofs file system mkdir inode operation blindly sets the created
    directory mode to S_IFDIR | 0555, ingoring the passed in mode, which can
    cause selinux dac_override denials.

    But the function also checks if the caller is the daemon (as no-one else
    should be able to do anything here) so there's no point in not honouring
    the passed in mode, allowing the daemon to set appropriate mode when
    required.

    Link: http://lkml.kernel.org/r/152361593601.8051.14014139124905996173.stgit@pluto.themaw.net
    Signed-off-by: Ian Kent <raven@themaw.net>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/autofs4/root.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/autofs4/root.c
    +++ b/fs/autofs4/root.c
    @@ -749,7 +749,7 @@ static int autofs4_dir_mkdir(struct inod

    autofs4_del_active(dentry);

    - inode = autofs4_get_inode(dir->i_sb, S_IFDIR | 0555);
    + inode = autofs4_get_inode(dir->i_sb, S_IFDIR | mode);
    if (!inode)
    return -ENOMEM;
    d_add(dentry, inode);

    \
     
     \ /
      Last update: 2018-04-22 17:13    [W:2.869 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site