lkml.org 
[lkml]   [2018]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 06/97] perf intel-pt: Fix timestamp following overflow
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Adrian Hunter <adrian.hunter@intel.com>

    commit 91d29b288aed3406caf7c454bf2b898c96cfd177 upstream.

    timestamp_insn_cnt is used to estimate the timestamp based on the number of
    instructions since the last known timestamp.

    If the estimate is not accurate enough decoding might not be correctly
    synchronized with side-band events causing more trace errors.

    However there are always timestamps following an overflow, so the
    estimate is not needed and can indeed result in more errors.

    Suppress the estimate by setting timestamp_insn_cnt to zero.

    Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: stable@vger.kernel.org
    Link: http://lkml.kernel.org/r/1520431349-30689-5-git-send-email-adrian.hunter@intel.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
    +++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
    @@ -1270,6 +1270,7 @@ static int intel_pt_overflow(struct inte
    intel_pt_clear_tx_flags(decoder);
    decoder->have_tma = false;
    decoder->cbr = 0;
    + decoder->timestamp_insn_cnt = 0;
    decoder->pkt_state = INTEL_PT_STATE_ERR_RESYNC;
    decoder->overflow = true;
    return -EOVERFLOW;

    \
     
     \ /
      Last update: 2018-04-22 16:46    [W:4.329 / U:0.504 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site