lkml.org 
[lkml]   [2018]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 19/61] iio: common: hid-sensors: simplify getting .drvdata
    On Thu, 19 Apr 2018 16:05:49 +0200
    Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:

    > We should get drvdata from struct device directly. Going via
    > platform_device is an unneeded step back and forth.
    >
    > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    Applied, thanks,

    Jonathan

    > ---
    >
    > Build tested only. buildbot is happy. Please apply individually.
    >
    > drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 9 +++------
    > 1 file changed, 3 insertions(+), 6 deletions(-)
    >
    > diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
    > index cfb6588565ba..2ce0efd98cc0 100644
    > --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
    > +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
    > @@ -304,8 +304,7 @@ EXPORT_SYMBOL(hid_sensor_setup_trigger);
    >
    > static int __maybe_unused hid_sensor_suspend(struct device *dev)
    > {
    > - struct platform_device *pdev = to_platform_device(dev);
    > - struct iio_dev *indio_dev = platform_get_drvdata(pdev);
    > + struct iio_dev *indio_dev = dev_get_drvdata(dev);
    > struct hid_sensor_common *attrb = iio_device_get_drvdata(indio_dev);
    >
    > return _hid_sensor_power_state(attrb, false);
    > @@ -313,8 +312,7 @@ static int __maybe_unused hid_sensor_suspend(struct device *dev)
    >
    > static int __maybe_unused hid_sensor_resume(struct device *dev)
    > {
    > - struct platform_device *pdev = to_platform_device(dev);
    > - struct iio_dev *indio_dev = platform_get_drvdata(pdev);
    > + struct iio_dev *indio_dev = dev_get_drvdata(dev);
    > struct hid_sensor_common *attrb = iio_device_get_drvdata(indio_dev);
    > schedule_work(&attrb->work);
    > return 0;
    > @@ -322,8 +320,7 @@ static int __maybe_unused hid_sensor_resume(struct device *dev)
    >
    > static int __maybe_unused hid_sensor_runtime_resume(struct device *dev)
    > {
    > - struct platform_device *pdev = to_platform_device(dev);
    > - struct iio_dev *indio_dev = platform_get_drvdata(pdev);
    > + struct iio_dev *indio_dev = dev_get_drvdata(dev);
    > struct hid_sensor_common *attrb = iio_device_get_drvdata(indio_dev);
    > return _hid_sensor_power_state(attrb, true);
    > }

    \
     
     \ /
      Last update: 2018-04-21 18:09    [W:4.225 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site