[lkml]   [2018]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 5/9] firmware: add functions to load firmware without warnings v4
On Sat, Apr 21, 2018 at 8:11 AM, Kees Cook <> wrote:
> What was the objection to using parameters for this? i.e. something
> like the gfp flags, but have a behavior flag FW_RQ_NOWAIT,
> FW_RQ_NOWARN, etc?

The objection was that the patches that I think Luis refers to

(a) passed in a union of random arguments

(b) changed all the users, even the ones that didn't want to be changed.

they were nasty and illegible and pointless.

Using some single flag field for an extended function, and leaving the
existing functions alone so that you don't have to convert existing
users - that would have been fine. That's not what was tried and


 \ /
  Last update: 2018-04-21 17:33    [W:0.098 / U:0.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site