Messages in this thread |  | | Date | Sat, 21 Apr 2018 21:46:05 +0100 | From | Javier Arteaga <> | Subject | Re: [PATCH 2/2] iio: adc128s052: add ACPI _HID AANT1280 |
| |
Hi Jonathan,
On Sat, Apr 21, 2018 at 05:05:05PM +0100, Jonathan Cameron wrote: > This is in principle fine, but I'd like to see it done somewhat more > explicitly. > > 1) Add the adc124s101 and similar families to the driver first. I think > this is just a case of IDs for all of > adc124s051 and adc124s101. > > 2) Add the ACPI ID as you have done here. > > That way we at least reflect clearly that the part is supported rather than > just in a comment on the ACPI ID.
Will do for v2.
Thank you!
|  |