lkml.org 
[lkml]   [2018]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 55/61] usb: mtu3: simplify getting .drvdata
    From
    Date
    hi,

    On Thu, 2018-04-19 at 16:06 +0200, Wolfram Sang wrote:
    > We should get drvdata from struct device directly. Going via
    > platform_device is an unneeded step back and forth.
    >
    > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    > ---
    >
    > Build tested only. buildbot is happy. Please apply individually.
    >
    > drivers/usb/mtu3/mtu3_plat.c | 6 ++----
    > 1 file changed, 2 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c
    > index 628d5ce356ca..46551f6d16fd 100644
    > --- a/drivers/usb/mtu3/mtu3_plat.c
    > +++ b/drivers/usb/mtu3/mtu3_plat.c
    > @@ -447,8 +447,7 @@ static int mtu3_remove(struct platform_device *pdev)
    > */
    > static int __maybe_unused mtu3_suspend(struct device *dev)
    > {
    > - struct platform_device *pdev = to_platform_device(dev);
    > - struct ssusb_mtk *ssusb = platform_get_drvdata(pdev);
    > + struct ssusb_mtk *ssusb = dev_get_drvdata(dev);
    >
    > dev_dbg(dev, "%s\n", __func__);
    >
    > @@ -466,8 +465,7 @@ static int __maybe_unused mtu3_suspend(struct device *dev)
    >
    > static int __maybe_unused mtu3_resume(struct device *dev)
    > {
    > - struct platform_device *pdev = to_platform_device(dev);
    > - struct ssusb_mtk *ssusb = platform_get_drvdata(pdev);
    > + struct ssusb_mtk *ssusb = dev_get_drvdata(dev);
    > int ret;
    >
    > dev_dbg(dev, "%s\n", __func__);

    Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

    Thanks



    \
     
     \ /
      Last update: 2018-04-20 09:46    [W:4.097 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site