lkml.org 
[lkml]   [2018]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] regulator: add QCOM RPMh regulator driver
On Fri, Apr 20 2018 at 13:07 -0600, David Collins wrote:
>On 04/18/2018 10:55 PM, Stephen Boyd wrote:
>> Quoting David Collins (2018-03-22 18:30:06)
>>> On 03/21/2018 12:07 PM, Stephen Boyd wrote:
>>>> Quoting David Collins (2018-03-16 18:09:10)
>>>>> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
>>>>> index 097f617..e0ecd0a 100644

>>>>> + ret = cmd_db_ready();
>>>>> + if (ret < 0) {
>>>>> + if (ret != -EPROBE_DEFER)
>>>>> + dev_err(dev, "Command DB not available, ret=%d\n", ret);
>>>>> + return ret;
>>>>> + }
>>>>
>>>> We should just make rpmh parent device call cmd_db_ready() so that these
>>>> devices aren't even populated until then and so that cmd_db_ready() is
>>>> only in one place. Lina?
>>>
>>> Let's see if Lina has qualms about this plan.
>>
>> Sounds like you're ok with it.
>
>Sure, I'll remove this check if Lina agrees to add it in the rpmh driver.
>
We want to make the RSC nodes child of Command DB? That way we probe the
controllers only if the command DB is ready?

I could do that. Just so you know, there is are no strict directives to
use Command DB. If a driver knows the information it needs to pass to
the accelerator, it may choose to skip command DB completely.

Thanks,
Lina

\
 
 \ /
  Last update: 2018-04-21 00:44    [W:0.149 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site