lkml.org 
[lkml]   [2018]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.
On Fri, Apr 20, 2018 at 05:55:28PM +0000, Mario.Limonciello@dell.com wrote:
>
> > -----Original Message-----
> > From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-x86-
> > owner@vger.kernel.org] On Behalf Of Randy Dunlap
> > Sent: Friday, April 20, 2018 12:53 PM
> > To: Limonciello, Mario; dvhart@infradead.org; Andy Shevchenko
> > Cc: LKML; platform-driver-x86@vger.kernel.org
> > Subject: Re: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.
> >
> > On 04/20/18 10:42, Mario Limonciello wrote:
> > > As reported by Randy Dunlap:
> > >>> WARNING: unmet direct dependencies detected for DELL_SMBIOS
> > >>> Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y]
> > >>> && (DCDBAS [=m] ||
> > >>> DCDBAS [=m]=n) && (ACPI_WMI [=n] || ACPI_WMI [=n]=n)
> > >>> Selected by [y]:
> > >>> - DELL_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y]
> > >>> && DMI [=y]
> > >>> && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] ||
> > >>> ACPI_VIDEO [=n]=n)
> > >>> && (RFKILL [=n] || RFKILL [=n]=n) && SERIO_I8042 [=y]
> > >>>
> > >
> > > Right now it's possible to set dell laptop to compile in but this
> > > causes dell-smbios to compile in which breaks if dcdbas is a module.
> > >
> > > Dell laptop shouldn't select dell-smbios anymore, but depend on it.
> > >
> > > Fixes: 32d7b19 (platform/x86: dell-smbios: Resolve dependency error on
> > DCDBAS)
> >
> > meta-comment: the SHA-1 ID should be the first 12 characters of the commit ID
> > according to Documentation/process/submitting-patches.rst.
>
> Thanks for letting me, I didn't realize that.
>
> Darren, let me know if you want me to resubmit with this adjustment or if you
> can adjust when you queue for testing.


Will fix locally.

--
Darren Hart
VMware Open Source Technology Center

\
 
 \ /
  Last update: 2018-04-20 23:53    [W:0.030 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site