Messages in this thread | | | Date | Fri, 20 Apr 2018 14:40:53 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v4] tracing: remove igrab() iput() call from uprobes.c |
| |
On Fri, 20 Apr 2018 18:36:38 +0000 Song Liu <songliubraving@fb.com> wrote:
> > On Apr 20, 2018, at 11:29 AM, Steven Rostedt <rostedt@goodmis.org> wrote: > > > > On Fri, 20 Apr 2018 11:08:47 -0700 > > Song Liu <songliubraving@fb.com> wrote: > > > >> For uprobes.c sisde, igrab() is not necessary. So we removed it and > > > > You don't need to send another patch, but what is the above sentence > > suppose to say? > > > > -- Steve > > > > Sorry for the typo. I meant "For uprobes.c side". Or "it is not necessary > to call igrab() in uprobe_register(), as the caller is required to keep > the inode reference. >
I'll update it to:
"For uprobes.c, it is not necessary to call igrab() in uprobe_register(), as the caller is required to keep the inode reference. The igrab() is removed and comments on this requirement is added to uprobe_register()."
-- Steve
| |