lkml.org 
[lkml]   [2018]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4] tracing: remove igrab() iput() call from uprobes.c
Date


> On Apr 20, 2018, at 11:29 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Fri, 20 Apr 2018 11:08:47 -0700
> Song Liu <songliubraving@fb.com> wrote:
>
>> For uprobes.c sisde, igrab() is not necessary. So we removed it and
>
> You don't need to send another patch, but what is the above sentence
> suppose to say?
>
> -- Steve
>

Sorry for the typo. I meant "For uprobes.c side". Or "it is not necessary
to call igrab() in uprobe_register(), as the caller is required to keep
the inode reference.

Song


>> added comments on requirements to callers of uprobe_register().



\
 
 \ /
  Last update: 2018-04-20 20:37    [W:0.057 / U:1.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site