Messages in this thread | | | Date | Fri, 20 Apr 2018 20:03:01 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/MCE, EDAC/mce_amd: Save all aux registers on SMCA systems |
| |
On Fri, Apr 20, 2018 at 01:05:17PM +0000, Ghannam, Yazen wrote: > Okay, I can do that. What about using mce_rdmsrl()? The value gets set to > 0 and a user gets a single warning. This may be more clear to the user. Also, > it shouldn't affect code that checks for non-zero values, like in __print_mce().
Hmm, good point. From the looks of it, it shouldn't be a problem and a MSR value of 0 is of no interest anyway. I *think*.
But pls make it a separate patch so that we can revert it in case something doesn't work as expected and we've missed a case.
Thx.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |