lkml.org 
[lkml]   [2018]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol
    On Fri, 20 Apr 2018 10:52:41 +0200
    Quentin Schulz <quentin.schulz@bootlin.com> wrote:

    > There's already ECC on NAND pages so there may be no need for one to
    > check the CRC of a UBI volume.

    That's true that ECC can help detecting corruptions, but I don't think
    this is the actual reason for disabling CRC check at volume open time.
    The actual reason for doing that is when the UBI volume user (in our
    case the squashfs FS) is also checking data consistency on its own
    (which is the case for squashfs).

    >
    > Let's introduce a ubi.nocheck parameter that let one skip the CRC check
    > when attaching a UBI volume.
    >
    > This also drastically speeds kernel boot by removing a potentially
    > useless check, e.g. I gained 3.2s on boot time of a SPEAr600-based board
    > for a ~20MB UBI volume used as rootfs.

    Can you give the old and new open/mount time instead of telling how
    much you gained on the whole boot-time?

    \
     
     \ /
      Last update: 2018-04-20 19:19    [W:2.536 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site