lkml.org 
[lkml]   [2018]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [REVIEW][PATCH 22/22] signal/xtensa: Use force_sig_fault where appropriate
    On Fri, Apr 20, 2018 at 7:38 AM, Eric W. Biederman
    <ebiederm@xmission.com> wrote:
    > Filling in struct siginfo before calling force_sig_info a tedious and
    > error prone process, where once in a great while the wrong fields
    > are filled out, and siginfo has been inconsistently cleared.
    >
    > Simplify this process by using the helper force_sig_fault. Which
    > takes as a parameters all of the information it needs, ensures
    > all of the fiddly bits of filling in struct siginfo are done properly
    > and then calls force_sig_info.
    >
    > In short about a 5 line reduction in code for every time force_sig_info
    > is called, which makes the calling function clearer.
    >
    > Cc: Max Filippov <jcmvbkbc@gmail.com>
    > Cc: Chris Zankel <chris@zankel.net>
    > Cc: linux-xtensa@linux-xtensa.org
    > Cc: linux-xtensa@linux-xtensa.org
    > Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
    > ---
    > arch/xtensa/kernel/traps.c | 10 +---------
    > arch/xtensa/mm/fault.c | 19 +++++--------------
    > 2 files changed, 6 insertions(+), 23 deletions(-)

    Acked-by: Max Filippov <jcmvbkbc@gmail.com>

    --
    Thanks.
    -- Max

    \
     
     \ /
      Last update: 2018-04-20 18:28    [W:4.136 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site