lkml.org 
[lkml]   [2018]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: qrtr: Expose tunneling endpoint to user space
From
From: Bjorn Andersson <bjorn.andersson@linaro.org>
Date: Wed, 18 Apr 2018 22:03:46 -0700

> +struct qrtr_tun {
> + struct qrtr_endpoint ep;
> +
> + struct mutex queue_lock;
> + struct sk_buff_head queue;
> + wait_queue_head_t readq;
> +};

The queue lock is surperfluous. sk_buff_head and all of the helpers you
are using does it's own locking. So you are essentially using two sets
of locks to protect the same object.

\
 
 \ /
  Last update: 2018-04-20 16:43    [W:0.030 / U:0.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site