Messages in this thread | | | Subject | Re: [PATCH 2/3] xen netback: add fault injection facility | From | Juergen Gross <> | Date | Fri, 20 Apr 2018 15:00:28 +0200 |
| |
On 20/04/18 14:52, staskins@amazon.com wrote: > On 04/20/18 13:25, Juergen Gross wrote: >> On 20/04/18 12:47, Stanislav Kinsburskii wrote: >>> + for (fi = 0; fi < XENVIF_FI_MAX; fi++) { >>> + vfi->faults[fi] = xen_fi_dir_add(vfi->dir, >>> + xenvif_fi_names[fi]); >> How does this work? xenvif_fi_names[] is an empty array and this is the >> only reference to it. Who is allocating the memory for that array? > > Well, it works in the way one adds a var to enum (which is used as a key > later) and a corresponding string into the array (which is used as a > name for the fault directory in sysfs).
Then you should size the array via XENVIF_FI_MAX.
Juergen
| |