lkml.org 
[lkml]   [2018]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata
    Hi Paul,

    On Fri, Apr 20, 2018 at 12:46 AM Paul Kocialkowski <
    paul.kocialkowski@bootlin.com> wrote:
    [snip]
    > +struct v4l2_ctrl_mpeg2_frame_hdr {
    > + __u32 slice_len;
    > + __u32 slice_pos;
    > + enum { MPEG1, MPEG2 } type;

    Is enum suitable for UAPI?

    > +
    > + __u16 width;
    > + __u16 height;
    > +
    > + enum { PCT_I = 1, PCT_P, PCT_B, PCT_D } picture_coding_type;

    Ditto.

    > + __u8 f_code[2][2];
    > +
    > + __u8 intra_dc_precision;
    > + __u8 picture_structure;
    > + __u8 top_field_first;
    > + __u8 frame_pred_frame_dct;
    > + __u8 concealment_motion_vectors;
    > + __u8 q_scale_type;
    > + __u8 intra_vlc_format;
    > + __u8 alternate_scan;
    > +
    > + __u8 backward_ref_index;
    > + __u8 forward_ref_index;
    > +};
    > +
    > #endif
    > diff --git a/include/uapi/linux/videodev2.h
    b/include/uapi/linux/videodev2.h
    > index 31b5728b56e9..4b8336f7bcf0 100644
    > --- a/include/uapi/linux/videodev2.h
    > +++ b/include/uapi/linux/videodev2.h
    > @@ -635,6 +635,7 @@ struct v4l2_pix_format {
    > #define V4L2_PIX_FMT_VC1_ANNEX_L v4l2_fourcc('V', 'C', '1', 'L') /*
    SMPTE 421M Annex L compliant stream */
    > #define V4L2_PIX_FMT_VP8 v4l2_fourcc('V', 'P', '8', '0') /* VP8 */
    > #define V4L2_PIX_FMT_VP9 v4l2_fourcc('V', 'P', '9', '0') /* VP9 */
    > +#define V4L2_PIX_FMT_MPEG2_FRAME v4l2_fourcc('M', 'G', '2', 'F') /*
    MPEG2 frame */

    > /* Vendor-specific formats */
    > #define V4L2_PIX_FMT_CPIA1 v4l2_fourcc('C', 'P', 'I', 'A') /* cpia1
    YUV */
    > @@ -1586,6 +1587,7 @@ struct v4l2_ext_control {
    > __u8 __user *p_u8;
    > __u16 __user *p_u16;
    > __u32 __user *p_u32;
    > + struct v4l2_ctrl_mpeg2_frame_hdr __user
    *p_mpeg2_frame_hdr;
    > void __user *ptr;
    > };
    > } __attribute__ ((packed));
    > @@ -1631,6 +1633,7 @@ enum v4l2_ctrl_type {
    > V4L2_CTRL_TYPE_U8 = 0x0100,
    > V4L2_CTRL_TYPE_U16 = 0x0101,
    > V4L2_CTRL_TYPE_U32 = 0x0102,
    > + V4L2_CTRL_TYPE_MPEG2_FRAME_HDR = 0x0109,

    Why 0x0109?

    Best regards,
    Tomasz

    \
     
     \ /
      Last update: 2018-04-20 11:52    [W:4.320 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site