lkml.org 
[lkml]   [2018]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH resend] usb: chipidea: Don't select EXTCON
Date

> >
> > Sorry to reply late, are you really care 2KB code side? Since many
> > users use EXTCON to handle vbus and id, it is hard just delete it. I
> > could accept patch for your specific platforms, like:
> >
> > + select EXTCON if !ARCH_XXXX
>
> The patch doesn't remove extcon support from chipidea driver.
> I just want to not select EXTCON unconditionally, but let the users choose. If the
> users need extcon, they could enable EXTCON themselves
>
> I just searched all the dts in arch/arm/boot/dts and arch/arm64/boot/dts only the four
> dts give extcon phandle to chipidea host, other users don't make use of it:
>
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
>
> arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
>
> arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts
>
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
>

I see, but I do not want to break msm platforms. You may try to create Glue driver Kconfig
entry for chipidea like dwc3, and let msm depends on EXTCON.

Peter

\
 
 \ /
  Last update: 2018-04-20 11:36    [W:0.070 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site