Messages in this thread | | | Date | Fri, 20 Apr 2018 01:31:47 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] sh: mm: Fix unprotected access to struct device |
| |
On Wed, Apr 18, 2018 at 03:13:14PM +0200, jacopo mondi wrote: > As long as it goes for arch/sh, the only user of dma_alloc_coherent() > is platform_resource_setup_memory(), and it has been fixed by this > patch.
Great!
> > Unfortunately, as Thomas pointed out, there are drivers which calls > into this with the wrong 'struct device' as the sh_eth one he had fixed.
Yes, we'll need fixes there. Other DMA ops implementations also look at struct device, so they generally are buggy.
> I would then say that as long as it goes for the NULL case, we should be > fine now.
Then I'd say skil that part, please.
| |