lkml.org 
[lkml]   [2018]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: ab8500: tidy ab8500_regulator_get_mode()
On Thu, 19 Apr 2018, Dan Carpenter wrote:

> The indenting here is confusing.
>
> Also we don't check "ret". That isn't likely to cause a runtime issue
> because if it fails here fails then we'd probably return -EINVAL at the
> end anyway. But it does introduce a static checker warning since "val"
> is only inititialized on the success path.
>
> drivers/regulator/ab8500.c:429 ab8500_regulator_get_mode()
> error: uninitialized symbol 'val'.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Lee Jones <lee.jones@linaro.org>

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2018-04-20 10:14    [W:0.025 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site