Messages in this thread |  | | Subject | Re: [PATCH net] net: dsa: mt7530: Use NULL instead of plain integer | From | Sean Wang <> | Date | Tue, 3 Apr 2018 10:18:24 +0800 |
| |
On Mon, 2018-04-02 at 16:24 -0700, Florian Fainelli wrote: > We would be passing 0 instead of NULL as the rsp argument to > mt7530_fdb_cmd(), fix that. >
Acked-by: Sean Wang <sean.wang@mediatek.com>
BTW, does the part of the commit message should be updated with "passing NULL instead of 0"?
> Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/net/dsa/mt7530.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 4e53c5ce23ff..a7f6c0a62fc7 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -917,7 +917,7 @@ mt7530_port_fdb_add(struct dsa_switch *ds, int port, > > mutex_lock(&priv->reg_mutex); > mt7530_fdb_write(priv, vid, port_mask, addr, -1, STATIC_ENT); > - ret = mt7530_fdb_cmd(priv, MT7530_FDB_WRITE, 0); > + ret = mt7530_fdb_cmd(priv, MT7530_FDB_WRITE, NULL); > mutex_unlock(&priv->reg_mutex); > > return ret; > @@ -933,7 +933,7 @@ mt7530_port_fdb_del(struct dsa_switch *ds, int port, > > mutex_lock(&priv->reg_mutex); > mt7530_fdb_write(priv, vid, port_mask, addr, -1, STATIC_EMP); > - ret = mt7530_fdb_cmd(priv, MT7530_FDB_WRITE, 0); > + ret = mt7530_fdb_cmd(priv, MT7530_FDB_WRITE, NULL); > mutex_unlock(&priv->reg_mutex); > > return ret; > @@ -1293,7 +1293,7 @@ mt7530_setup(struct dsa_switch *ds) > } > > /* Flush the FDB table */ > - ret = mt7530_fdb_cmd(priv, MT7530_FDB_FLUSH, 0); > + ret = mt7530_fdb_cmd(priv, MT7530_FDB_FLUSH, NULL); > if (ret < 0) > return ret; >
|  |