Messages in this thread |  | | From | NeilBrown <> | Date | Tue, 03 Apr 2018 08:39:55 +1000 | Subject | Re: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c |
| |
On Mon, Apr 02 2018, Christian Lütke-Stetzkamp wrote:
> On Mon, Apr 02, 2018 at 01:41:33PM +1000, NeilBrown wrote: >> On Mon, Apr 02 2018, Sean Wang wrote: >> > Hi, Neil >> > >> > Forgive me I cannot find the cover letter in the original series in my >> > mailbox to make a reply, so I rudely made here just letting you know >> > something good to the growth of mt7621 support in upstream. >> > >> > If so, it would become a bit easier for me that maybe I could give a >> > hand for migrating these staging driver for mt7621 to mainline. I >> > thought mmc, pci, ethernet, gsw and hsdma all could probably reuse the >> > current mainline code. >> >> I agree that it is quite likely that several of these drivers could and >> should reuse current mainline code. I would love to have some help >> sorting this out. I won't have much time myself to dig into it for >> several weeks, but I'll make time to review and test any code that is >> contributed. >> >> Thanks, >> NeilBrown > > Hi, > > I have started a patch series for the mmc driver that is currently in > staging, that makes some of the first cleanups (whitespace, indent,..) > and also starts to clean up the code, to make the similarities and > differences to the current mainline code clearer. The series is far > from being complete, but I think I'm going to send it out today, so > you can look and comment. > > I would suggest that we continue cleaning the code that is currently > in staging to remove the dead parts and make the diff to the mainline > code obvious. Do you agree with that proposal or do you suggest a > different plan?
I think this is an excellent plan - thanks for doing it. I'll hopefully look over your patches today and send any comments.
Thanks, NeilBrown [unhandled content-type:application/pgp-signature] |  |