Messages in this thread |  | | Subject | Re: [PATCH 2/2] blk-mq: Fix request handover from timeout path to normal execution | From | Bart Van Assche <> | Date | Mon, 2 Apr 2018 14:08:37 -0700 |
| |
On 04/02/18 12:01, Tejun Heo wrote: > + * As nothing prevents from completion happening while > + * ->aborted_gstate is set, this may lead to ignored completions > + * and further spurious timeouts. > + */ > + if (rq->rq_flags & RQF_MQ_TIMEOUT_RESET) > + blk_mq_rq_update_aborted_gstate(rq, 0);
Hello Tejun,
Since this patch fixes one race but introduces another race, is this patch really an improvement?
Thanks,
Bart.
|  |