[lkml]   [2018]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] nvmet: fix nvmet_execute_write_zeroes function
Thanks Keith. The patch you proposed worked fine!!

I just sent a V2 with that change!

On 04/02/2018 11:21 AM, Keith Busch wrote:
> On Mon, Apr 02, 2018 at 10:47:10AM -0300, Rodrigo Rosatti Galvao wrote:
>> One thing that I just forgot to explain previously, but I think its
>> relevant:
>> 1. The command is failing with 4k logical block size, but works with 512B
>> 2. With the patch, the command is working for both 512B and 4K.
> While you're not getting errors with your patch, you're not zeroing out
> the requested blocks, so that's a data corruption.
> The issue is the +1 is in the wrong place. It needs to be added to the
> native format prior to converting it to a 512b sector count. Do you want
> to resend with that change?
> _______________________________________________
> Linux-nvme mailing list

Rodrigo R. Galvão
Intern - Linux Technology Center - IBM

 \ /
  Last update: 2018-04-02 16:51    [W:0.043 / U:2.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site