Messages in this thread |  | | Date | Mon, 2 Apr 2018 08:21:42 -0600 | From | Keith Busch <> | Subject | Re: [PATCH] nvmet: fix nvmet_execute_write_zeroes function |
| |
On Mon, Apr 02, 2018 at 10:47:10AM -0300, Rodrigo Rosatti Galvao wrote: > One thing that I just forgot to explain previously, but I think its > relevant: > > 1. The command is failing with 4k logical block size, but works with 512B > > 2. With the patch, the command is working for both 512B and 4K.
While you're not getting errors with your patch, you're not zeroing out the requested blocks, so that's a data corruption.
The issue is the +1 is in the wrong place. It needs to be added to the native format prior to converting it to a 512b sector count. Do you want to resend with that change?
|  |