Messages in this thread |  | | Subject | Re: [PATCH v5 06/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.1-c1 board file | From | Sricharan R <> | Date | Mon, 2 Apr 2018 11:04:21 +0530 |
| |
Hi Bjorn,
On 3/27/2018 10:42 PM, Bjorn Andersson wrote: > On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: >> +#include "qcom-ipq4019-ap.dk04.1.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1-C1"; >> + > > If this is the board and qcom-ipq4019-ap.dk04.1.dtsi is the platform > file then the compatible should be here and not there. Also qcom,ipq4019 > is not an awesome compatible for a board file. >
ok, agree. Will correct the compatible and move it here.
>> + soc { >> + dma@7984000 { >> + status = "ok"; >> + }; >> + >> + qpic-nand@79b0000 { >> + pinctrl-0 = <&nand_pins>; >> + pinctrl-names = "default"; >> + status = "ok"; >> + }; > > nand_pins defines the muxing and is defined in the other dtsi. So please > move these pinctrl-* properties to the dtsi. > > As long as the node is disabled the pinctrl state won't be applied > anyways. > > > If there are electrical properties that needs to be specified you can > override the pinctrl state in the board specific file. >
ok, understood. Will follow these conventions in rest of the places as well.
Regards, Sricharan
-- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
|  |