lkml.org 
[lkml]   [2018]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v8 42/42] ARM: dts: da850: Add clocks
    From
    Date
    On Friday 16 March 2018 10:50 PM, David Lechner wrote:
    > On 03/15/2018 09:52 PM, David Lechner wrote:
    >> This adds clock provider nodes for da850 and wires them up to all of the
    >> devices.
    >>
    >> Signed-off-by: David Lechner <david@lechnology.com>
    >> ---
    >
    > ...
    >
    > This is the mcasp0: mcasp@100000 node...
    >
    >> @@ -560,6 +720,7 @@
    >>               dmas = <&edma0 1 1>,
    >>                   <&edma0 0 1>;
    >>               dma-names = "tx", "rx";
    >> +            clocks = <&psc1 7>;
    >
    > After some testing, it looks like it needs to be:
    >
    > +            power-domains = <&psc1 7>;
    >
    > instead of
    >
    > +            clocks = <&psc1 7>;

    We should probably have both clocks and power-domains properties for all
    PSC clocks. This way, the driver can change without a corresponding DT
    update dependency.

    Thanks,
    Sekhar

    \
     
     \ /
      Last update: 2018-04-02 13:14    [W:5.356 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site