Messages in this thread | | | From | Peter Chen <> | Subject | RE: [PATCH resend] usb: chipidea: Don't select EXTCON | Date | Fri, 20 Apr 2018 01:38:42 +0000 |
| |
> drivers/usb/chipidea/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig index > 785f0ed037f7..97509172d536 100644 > --- a/drivers/usb/chipidea/Kconfig > +++ b/drivers/usb/chipidea/Kconfig > @@ -1,7 +1,6 @@ > config USB_CHIPIDEA > tristate "ChipIdea Highspeed Dual Role Controller" > depends on ((USB_EHCI_HCD && USB_GADGET) || (USB_EHCI_HCD > && !USB_GADGET) || (!USB_EHCI_HCD && USB_GADGET)) && HAS_DMA > - select EXTCON > select RESET_CONTROLLER > help > Say Y here if your system has a dual role high speed USB > -- > 2.17.0
Hi Jisheng,
Sorry to reply late, are you really care 2KB code side? Since many users use EXTCON to handle vbus and id, it is hard just delete it. I could accept patch for your specific platforms, like:
+ select EXTCON if !ARCH_XXXX
But please note, even your board uses SoC id/vbus pin to detect related external signal, the other boards use the same SoC may use external gpios to do it.
Peter
| |