lkml.org 
[lkml]   [2018]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] virtio_ring: switch to dma_XX barriers for rpmsg
From
Date
On 19/04/2018 19:46, Michael S. Tsirkin wrote:
>> This should be okay, but I wonder if there should be a virtio_wmb(...)
>> or an "if (weak_barriers) wmb()" before the "writel" in vm_notify
>> (drivers/virtio/virtio_mmio.c).
>>
>> Thanks,
>>
>> Paolo
> That one uses weak barriers AFAIK.
>
> IIUC you mean rproc_virtio_notify.
>
> I suspect it works because specific kick callbacks have a barrier internally.

Yes, that one. At least keystone_rproc_kick doesn't seem to have a barrier.

Paolo

\
 
 \ /
  Last update: 2018-04-19 19:49    [W:0.806 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site