Messages in this thread | | | Date | Thu, 19 Apr 2018 17:29:33 +0200 | From | Borislav Petkov <> | Subject | Re: [RFC PATCH v2 2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc |
| |
On Thu, Apr 19, 2018 at 09:57:08AM -0500, Alex G. wrote: > And that was the motivation behind my splitting it in this patch.
By "split" I don't mean add a function pointer which gets selected and then called - if the function becomes too long, you simply split the function body properly.
> You don't need the entire GHES structure -- wide context. Individual > handlers should not be able to access the entire ghes.
But you remove the @ghes argument in patch 1. So what are we even talking about?
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |