Messages in this thread Patch in this message | | | Subject | Re: [linux-sunxi] [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver | From | Paul Kocialkowski <> | Date | Thu, 19 Apr 2018 16:56:05 +0200 |
| |
Hi,
On Mon, 2018-03-12 at 20:29 +0000, Joonas Kylmälä wrote: > Paul Kocialkowski: > > diff --git a/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > > b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > > new file mode 100644 > > index 000000000000..88624035e0e3 > > --- /dev/null > > +++ b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > > @@ -0,0 +1,313 @@ > > +/* > > + * Sunxi Cedrus codec driver > > + * > > + * Copyright (C) 2016 Florent Revest > > + * Florent Revest <florent.revest@free-electrons.com> > > + * > > + * Based on vim2m > > + * > > + * Copyright (c) 2009-2010 Samsung Electronics Co., Ltd. > > + * Pawel Osciak, <pawel@osciak.com> > > + * Marek Szyprowski, <m.szyprowski@samsung.com> > > + * > > + * This software is licensed under the terms of the GNU General > > Public > > + * License version 2, as published by the Free Software Foundation, > > and > > + * may be copied, distributed, and modified under those terms. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include "sunxi_cedrus_common.h" > > + > > +#include <linux/clk.h> > > +#include <linux/module.h> > > +#include <linux/delay.h> > > +#include <linux/fs.h> > > +#include <linux/sched.h> > > +#include <linux/slab.h> > > +#include <linux/of.h> > > + > > +#include <linux/platform_device.h> > > +#include <linux/videodev2.h> > > +#include <media/v4l2-mem2mem.h> > > +#include <media/v4l2-device.h> > > +#include <media/v4l2-ioctl.h> > > +#include <media/v4l2-ctrls.h> > > +#include <media/v4l2-event.h> > > +#include <media/videobuf2-dma-contig.h> > I think that the definitions > > #include <linux/clk.h> > #include <linux/delay.h> > #include <linux/fs.h> > #include <linux/sched.h> > #include <linux/slab.h> > #include <linux/videodev2.h> > > are not used directly in the sunxi_cedrus.c file. Therefore they > should be removed.
Thanks for the review, this will be done in v2.
Cheers,
-- Paul Kocialkowski, Bootlin (formerly Free Electrons) Embedded Linux and kernel engineering https://bootlin.com[unhandled content-type:application/pgp-signature] | |