lkml.org 
[lkml]   [2018]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/2] regulator: add QCOM RPMh regulator driver
Date
Quoting David Collins (2018-04-18 16:30:26)
> On 04/17/2018 01:02 PM, Doug Anderson wrote:
> > On Fri, Apr 13, 2018 at 7:50 PM, David Collins <collinsd@codeaurora.org> wrote:
> >> +#define RPMH_REGULATOR_DISABLE 0x0
> >> +#define RPMH_REGULATOR_ENABLE 0x1
> >
> > In the last version Stephen said he didn't like the above two #defines
> > and you said you'd remove them, yet they are still here. Explanation?
>
> I thought that he was referring to the comments above the constants since
> his review comment was immediately following the second of two comments as
> opposed to these constants. I'll let him follow-up on this point if
> necessary.
>

I think I was talking about the comments. The defines don't look super
useful either though.

\
 
 \ /
  Last update: 2018-04-19 08:05    [W:0.133 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site