Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: [PATCH v2 2/2] regulator: add QCOM RPMh regulator driver | Date | Wed, 18 Apr 2018 23:04:31 -0700 |
| |
Quoting David Collins (2018-04-18 16:30:26) > On 04/17/2018 01:02 PM, Doug Anderson wrote: > > On Fri, Apr 13, 2018 at 7:50 PM, David Collins <collinsd@codeaurora.org> wrote: > >> +#define RPMH_REGULATOR_DISABLE 0x0 > >> +#define RPMH_REGULATOR_ENABLE 0x1 > > > > In the last version Stephen said he didn't like the above two #defines > > and you said you'd remove them, yet they are still here. Explanation? > > I thought that he was referring to the comments above the constants since > his review comment was immediately following the second of two comments as > opposed to these constants. I'll let him follow-up on this point if > necessary. >
I think I was talking about the comments. The defines don't look super useful either though.
| |