Messages in this thread | | | Subject | Re: [PATCH] ipmi_ssif: Fix uninitialized variable issue | From | Corey Minyard <> | Date | Thu, 19 Apr 2018 08:40:47 -0500 |
| |
On 04/19/2018 08:24 AM, Gustavo A. R. Silva wrote: > Currently, function ssif_remove returns _rv_, which is a variable that > is never initialized. > > Fix this by removing variable _rv_ and return 0 instead.
This fix is in my next tree now, thanks for catching this before it got any further than that.
-corey
> Addresses-Coverity-ID: 1467999 ("Uninitialized scalar variable") > Fixes: 6a0d23ed338e ("ipmi: ipmi_unregister_smi() cannot fail, have it > return void") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/char/ipmi/ipmi_ssif.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index ecabfe2..37f9ae2 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1227,7 +1227,6 @@ static int ssif_remove(struct i2c_client *client) > struct ssif_info *ssif_info = i2c_get_clientdata(client); > struct ipmi_smi *intf; > struct ssif_addr_info *addr_info; > - int rv; > > if (!ssif_info) > return 0; > @@ -1247,7 +1246,7 @@ static int ssif_remove(struct i2c_client *client) > } > } > > - return rv; > + return 0; > } > > static int do_cmd(struct i2c_client *client, int len, unsigned char *msg,
| |