Messages in this thread | | | Subject | Re: [PATCH 2/2] memory: aemif: add support for board files | From | Sekhar Nori <> | Date | Thu, 19 Apr 2018 17:39:26 +0530 |
| |
On Wednesday 18 April 2018 09:05 PM, Bartosz Golaszewski wrote: > @@ -373,15 +372,23 @@ static int aemif_probe(struct platform_device *pdev) > goto error; > } > > - /* > - * For every controller device node, there is a cs device node that > - * describe the bus configuration parameters. This functions iterate > - * over these nodes and update the cs data array. > - */ > - for_each_available_child_of_node(np, child_np) { > - ret = of_aemif_parse_abus_config(pdev, child_np); > - if (ret < 0) > - goto error; > + if (np) { > + /* > + * For every controller device node, there is a cs device node > + * that describe the bus configuration parameters. This > + * functions iterate over these nodes and update the cs data > + * array. > + */ > + for_each_available_child_of_node(np, child_np) { > + ret = of_aemif_parse_abus_config(pdev, child_np); > + if (ret < 0) > + goto error; > + } > + } else if (pdata && pdata->num_abus_data > 0) { > + for (i = 0; i < pdata->num_abus_data; i++, aemif->num_cs++) { > + aemif->cs_data[i].cs = pdata->abus_data->cs;
Since abus_data is an array, shouldn't it be pdata->abus_data[i].cs ?
Thanks, Sekhar
| |