Messages in this thread | | | Subject | Re: [PATCH v8 2/2] drm: bridge: Add thc63lvd1024 LVDS decoder driver | From | Vladimir Zapolskiy <> | Date | Thu, 19 Apr 2018 14:18:30 +0300 |
| |
Hi Jacopo,
On 04/10/2018 01:53 PM, Jacopo Mondi wrote: > Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel > output converter. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Generally I have only one pretty ignorable comment.
> + > +enum thc63_ports { > + THC63_LVDS_IN0, > + THC63_LVDS_IN1, > + THC63_RGB_OUT0, > + THC63_RGB_OUT1, > +}; > +
The driver uses only THC63_RGB_OUT0 value, or port@2, and MODE{0,1,2} IC configuration is ignored.
I don't know if right from the beginning it would be better to support dual-out modes, preferably both single-in and dual-in ones. Will it impact port enumeration?
I do understand that the extension is possible, and likely only hardware accessibility postpones it.
-- With best wishes, Vladimir
| |