lkml.org 
[lkml]   [2018]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH 1/4] ALSA: usb: stream: refactor audio interface parsing
On Sat, 14 Apr 2018 00:24:23 +0200,
Ruslan Bilovol wrote:
>
> Offload snd_usb_parse_audio_interface() function which
> became quite long after adding UAC3 spec support.
>
> Move class-specific parts to separate functions
> which now produce audioformat structure that is
> ready to be fed to snd_usb_add_audio_stream().
>
> This also broke Blue Microphones workaround (which
> relies on audioformat decoded from previous altsetting)
> into two parts: prepare quirk flag analyzing previous
> altsetting then use it with current altsetting.
>
> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>

Could you try to split this patch to two parts: one is a simple
refactoring to move the code to snd_usb_get_audioformat_uac12(), and
another to add snd_usb_get_audioformat_uac3().

In this way, we can see a problem more clearly if it's in the
refactoring part.


thanks,

Takashi

\
 
 \ /
  Last update: 2018-04-19 11:56    [W:0.087 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site