Messages in this thread | | | Subject | Re: [PATCH v8 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder | From | Vladimir Zapolskiy <> | Date | Thu, 19 Apr 2018 12:44:32 +0300 |
| |
Hi Jacopo, Laurent,
On 04/10/2018 01:53 PM, Jacopo Mondi wrote: > Document Thine THC63LVD1024 LVDS decoder device tree bindings. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> --- > .../bindings/display/bridge/thine,thc63lvd1024.txt | 60 ++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > new file mode 100644 > index 0000000..0b23e70 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > @@ -0,0 +1,60 @@ > +Thine Electronics THC63LVD1024 LVDS decoder > +------------------------------------------- > + > +The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS streams > +to parallel data outputs. The chip supports single/dual input/output modes, > +handling up to two LVDS input streams and up to two digital CMOS/TTL outputs. > + > +Single or dual operation mode, output data mapping and DDR output modes are > +configured through input signals and the chip does not expose any control bus. > + > +Required properties: > +- compatible: Shall be "thine,thc63lvd1024" > +- vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS input, > + PPL and digital circuitry > + > +Optional properties: > +- powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low
Thank you for the change.
I would suggest to rename 'pwdn-gpios' property of THC63LVDM83D as well, as far as I understand it is only described in DT bindings documentation, and the property is unused in the driver or board DTS files at the moment.
> +- oe-gpios: Output enable GPIO signal, pin name "OE". Active high
Okay :)
-- With best wishes, Vladimir
| |