[lkml]   [2018]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()
On Thu, Apr 19, 2018 at 08:56:28AM +1000, NeilBrown wrote:
> I don't want to do that - I just want the documentation to be correct
> (or at least, not be blatantly incorrect). The function does not sleep,
> and is safe to call with spin locks held.
> Do we need to spell out when it can be called? If so, maybe:
> This function may be called from any process context, including
> non-preemptable context, but cannot be called from interrupts.

Just to make it perfectly clear, how about "cannot be called from
softirq or hardirq context"? Previously the not able to sleep part
completely ruled out any ambiguity but the new wording could confuse
people into thinking that this can be called from softirq context
where it would be unsafe if mixed with process context usage.

Email: Herbert Xu <>
Home Page:
PGP Key:

 \ /
  Last update: 2018-04-19 05:23    [W:0.062 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site