lkml.org 
[lkml]   [2018]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] printk: wake up klogd in vprintk_emit
On (04/18/18 11:10), Steven Rostedt wrote:
>
> > > Calling wake_up_klogd() will grab the rq lock and give us a A-B<->B-A
> > > locking order.
> >
> > wake_up_klogd() uses the lockless irq_work_queue(). So it is actually
> > safe.
>
> I didn't look at the code. OK then we don't need to worry about that.

OK.

> >
> > But the name is confusing. We should rename it.
>
> Yes, I would because the old wake_up_klogd() did do a wakeup. Perhaps
> we should name it: kick_klogd().

Agreed.

-ss

\
 
 \ /
  Last update: 2018-04-19 03:17    [W:3.132 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site