[lkml]   [2018]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
On 4/18/2018 4:16 PM, Mehta, Sohil wrote:
> On Wed, 2018-04-18 at 08:31 +0000, Yang, Shunyong wrote:
>> Maybe the original design is to call debugfs_initialized() before
>> calling debugfs_create_xxx()?
> I am unaware of the original design. Someone else would probably have
> more context. However, looking at other places in the kernel where
> debugfs_create_xx() is used, the common convention seems to be to avoid
> calling debugfs_initialized().
>  Sohil

debugfs_initialized() was introduced in commit c0f92ba99 back in
2.6.30-rc1. It was intended as a helper, not as a gatekeeper, which is
why one doesn't see it used. Given that my use in this proposed patch is
straightforward, I'm not seeing the need here. I had just seen some
other code that used it, and copied the model.

Unless someone comes along to say, yes, use it, I'll not.


 \ /
  Last update: 2018-04-18 22:52    [W:0.045 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site