Messages in this thread | | | Subject | Re: [PATCH] [media] include/media: fix missing | operator when setting cfg | From | Sylwester Nawrocki <> | Date | Wed, 18 Apr 2018 17:23:25 +0200 |
| |
On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: > On 04/18/2018 05:06 PM, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >> this is not being used and cfg is being re-assigned. I believe the >> assignment operator should actually be instead the |= operator. >> >> Detected by CoverityScan, CID#1467987 ("Unused value") >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> > Thanks for the patch. > > Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
I forgot to mention that the subject should rather looks something like:
"exynos4-is: fimc-lite: : fix missing | operator when setting cfg"
-- Regards, Sylwester
| |