[lkml]   [2018]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe:Re: [PATCH v3] net: davicom: dm9000: Avoid spinlock recursion during dm9000_timeout routine

Because the timeout task gets the main spinlock and disable the current cpu's irq,
there is no other task on the same cpu can run, and tasks on the other cpus can not
enter the dm9000_timeout() again. So in the whole dm9000_timeout() routine,
db->timeout_cpu can not be changed by other tasks. Although smp_processor_id() may change
after preempt_enable(), these tasks always get the false result when call dm9000_current_in_timeout.
Only the timeout task get the true result. And if there is no timeout, all the tasks that want to
do asynchronous phy operation get the false result. So I think this can avoid racy.

At 2018-04-16 23:05:01, "David Miller" <> wrote:
>From: Liu Xiang <>
>Date: Sat, 14 Apr 2018 16:50:34 +0800
>> +static bool dm9000_current_in_timeout(struct board_info *db)
>> +{
>> + bool ret = false;
>> +
>> + preempt_disable();
>> + ret = (db->timeout_cpu == smp_processor_id());
>> + preempt_enable();
>This doesn't work.
>As soon as you do preempt_enable(), smp_processor_id() can change.
 \ /
  Last update: 2018-04-18 15:49    [W:0.046 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site