[lkml]   [2018]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/4] ASoC: dwc: I2S Controller instance param added

On Tuesday 17 April 2018 09:39 PM, Mark Brown wrote:
> On Tue, Apr 17, 2018 at 10:29:51AM +0530, Vijendar Mukunda wrote:
>> +#define I2S_SP_INSTANCE 1
>> +#define I2S_BT_INSTANCE 2
> This is obviously very specific to the system you're working with and
> therefore doesn't belong in the generic driver. The device should be
> dealing with its own configuration, it shouldn't need to know about what
> specifically is connected to it. It's not even clear what they're doing
> in this driver given that there doesn't appear to be any use of the
> information, it feels like this is something that the machine driver
> should be encapsulating.
> Like I said with previous reviews this use of magic numbers for the
> interfaces is a bit of a red flag, internally within a driver they're
> fine but they shouldn't leak out too much except with things like
> numbering an array.

I will remove macros from designware header file and I will re spin
the patch set

 \ /
  Last update: 2018-04-18 11:39    [W:0.053 / U:2.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site